The entry mask of __copy_tofrom_user() is wrong -- temporary registers need no saving normally and we do not call this function from any special context to make it any different in this respect. Thanks, Jan-Benedict, for catching this one! Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org> --- Please apply. Eventually our implementation of the ENTRY() macro should mimic what the userland variation does, that is accept the mask as its second argument. But that should be done as a separate patch with no semantic changes. Maciej patch-mips-2.6.25-20080422-vax-copy-user-mask-2 diff -up --recursive --new-file linux-mips-2.6.25-20080422.macro/arch/vax/lib/copy_tofrom_user.S linux-mips-2.6.25-20080422/arch/vax/lib/copy_tofrom_user.S --- linux-mips-2.6.25-20080422.macro/arch/vax/lib/copy_tofrom_user.S 2008-05-01 00:00:00.000000000 +0000 +++ linux-mips-2.6.25-20080422/arch/vax/lib/copy_tofrom_user.S 2009-05-01 23:21:09.000000000 +0000 @@ -19,7 +19,7 @@ .text ENTRY(__copy_tofrom_user) - .word 0x3e + .word 0x0000 movl 4(%ap), %r2 /* to in r2 */ movl 8(%ap), %r3 /* from in r3 */ movl 12(%ap), %r0 /* size in r0 */ _______________________________________________ Linux-Vax mailing list Linux-Vax@mail.pergamentum.com http://mail.pergamentum.com/mailman/listinfo/linux-vax